build: add python 3.13 to test matrix #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ships
force-pushed
the
ships/add-python-versions
branch
from
8e9c399 to
218e5cd
Compare
ships
force-pushed
the
ships/add-python-versions
branch
from
218e5cd to
a01c31b
Compare
|
🥷 Code experts: no user matched threshold 10 Joaoloula has most 🧠 knowledge in the files. See details
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
ships
force-pushed
the
ships/add-python-versions
branch
from
a01c31b to
5a34b15
Compare
ships
force-pushed
the
ships/add-python-versions
branch
from
5a34b15 to
9cae010
Compare
paxan
approved these changes
Mar 11, 2025
| @@ -29,7 +28,7 @@ requires-python = ">= 3.9" | |||
| [project.optional-dependencies] | |||
| cuda = [ | |||
| "jax[cuda12]>=0.4.29", | |||
| "jaxlib[cuda12_pip]>=0.4.29", | |||
| "jaxlib[cuda12]>=0.4.29", | |||
There was a problem hiding this comment.
Ha! Thank you for fixing this. I've been seeing warnings about non-existence of [cuda12_pip] during some local builds on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though this package is specified as Python 3.9 or greater, we are interested in expanding to use python 3.13, so this PR adds that to the test matrix for compatibility confidence.
Because all libraries we know of that use this package have separate dependencies on 3.12+ , this package's tested support for 3.9 - 3.11 is OPTIONAL and may be dropped.
@sritchie , we over here expect to be responsible for these PRs approvals and merging, but tagging you as a reviewer in case you want to adjust course as we get that flow off the ground.