Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement verify function #4

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Implement verify function #4

merged 1 commit into from
Mar 28, 2023

Conversation

huming2207
Copy link
Contributor

Hi @Yatekii

This PR implements the Verify() function mentioned in this issue: probe-rs/flash-algorithm-template#5

I haven't tested that but it should work, so I've created a draft PR first.

Regards,
Jackson Hu

@huming2207 huming2207 marked this pull request as ready for review March 6, 2023 11:03
@huming2207
Copy link
Contributor Author

I think I've got no more to commit here, please go ahead to review. Thanks.

@huming2207
Copy link
Contributor Author

Any updates?

Yatekii
Yatekii approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Yatekii Yatekii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long ...

@Yatekii Yatekii merged commit d0e632e into probe-rs:master Mar 28, 2023
@huming2207
Copy link
Contributor Author

all good, thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yatekii Yatekii Yatekii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huming2207 @Yatekii