Skip to content

use the same style for MIDI channel selection as for master volume #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soyersoyer
Copy link
Contributor

@soyersoyer soyersoyer commented Jul 7, 2025

This is just a style update, and so there is no need to call Release() separately.

This is better in this way because you don't have to call Release() again and then return for a new if condition.

But is this code good? According to the manual, wouldn't the 3rd byte be the new channel?
Isn't the channel numbered 1-16 (Data column in the manual)?
image
image

Copy link

github-actions bot commented Jul 7, 2025

Build for testing:
MiniDexed_1195_2025-07-07-b309961_32bit
MiniDexed_1195_2025-07-07-b309961_64bit
Use at your own risk.

@probonopd
Copy link
Owner

But is this code good? According to the manual, wouldn't the 3rd byte be the new channel?

Not entirely sure I understand your question fully, but

we interpret the device parameter as the number of the TG (unlike the TX816/TX216 which has a hardware switch to select the TG)

@soyersoyer
Copy link
Contributor Author

we interpret the device parameter as the number of the TG (unlike the TX816/TX216 which has a hardware switch to select the TG)

Ah OK. So 2nd byte is the TG, the 5th byte is the channel (0-15).

Copy link

github-actions bot commented Jul 7, 2025

Build for testing:
MiniDexed_1196_2025-07-07-d7c6de1_32bit
MiniDexed_1196_2025-07-07-d7c6de1_64bit
Use at your own risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants