Skip to content

use the same style for MIDI channel selection as for master volume#945

Merged
probonopd merged 1 commit intoprobonopd:mainfrom
soyersoyer:fixchan
Jul 23, 2025
Merged

use the same style for MIDI channel selection as for master volume#945
probonopd merged 1 commit intoprobonopd:mainfrom
soyersoyer:fixchan

Conversation

@soyersoyer
Copy link
Contributor

@soyersoyer soyersoyer commented Jul 7, 2025

This is just a style update, and so there is no need to call Release() separately.

This is better in this way because you don't have to call Release() again and then return for a new if condition.

But is this code good? According to the manual, wouldn't the 3rd byte be the new channel?
Isn't the channel numbered 1-16 (Data column in the manual)?
image
image

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Build for testing:
MiniDexed_1195_2025-07-07-b309961_32bit
MiniDexed_1195_2025-07-07-b309961_64bit
Use at your own risk.

@probonopd
Copy link
Owner

But is this code good? According to the manual, wouldn't the 3rd byte be the new channel?

Not entirely sure I understand your question fully, but

we interpret the device parameter as the number of the TG (unlike the TX816/TX216 which has a hardware switch to select the TG)

@soyersoyer
Copy link
Contributor Author

we interpret the device parameter as the number of the TG (unlike the TX816/TX216 which has a hardware switch to select the TG)

Ah OK. So 2nd byte is the TG, the 5th byte is the channel (0-15).

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Build for testing:
MiniDexed_1196_2025-07-07-d7c6de1_32bit
MiniDexed_1196_2025-07-07-d7c6de1_64bit
Use at your own risk.

@probonopd
Copy link
Owner

Do you think this should be merged now @soyersoyer?

@soyersoyer
Copy link
Contributor Author

Yes

@probonopd probonopd merged commit 81e66a7 into probonopd:main Jul 23, 2025
3 checks passed
@soyersoyer soyersoyer deleted the fixchan branch December 3, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants