use the same style for MIDI channel selection as for master volume#945
use the same style for MIDI channel selection as for master volume#945probonopd merged 1 commit intoprobonopd:mainfrom
Conversation
|
Build for testing: |
Not entirely sure I understand your question fully, but
|
Ah OK. So 2nd byte is the TG, the 5th byte is the channel (0-15). |
|
Build for testing: |
|
Do you think this should be merged now @soyersoyer? |
|
Yes |
This is just a style update, and so there is no need to call Release() separately.
This is better in this way because you don't have to call Release() again and then return for a new if condition.
But is this code good?According to the manual, wouldn't the 3rd byte be the new channel?Isn't the channel numbered 1-16 (Data column in the manual)?