[WIP] Noiseless parameter change #955
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 1ec9cb2.
they will be overwritten later
It doesn't work well if multiplier[channel]==UNITY_GAIN
so one scale per element is enough
0.0 full left 1.0 full right
as it's fixed in the pan
There is no pop when changing the volume at zero crossing. Or less if there is DC. This makes the panning less noisy.
|
Build for testing: |
|
Build for testing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to be able to change any parameter while playing without any pops and clicks.
In principle, it is possible if the parameter change occurs at zero crossing.
I wrote zero cross detection for panning and TG Volume / Expression change, it works.
However, some performances have a DC component, and there is a bit of noise with those.
I will change the other parameters as well.
Until then, you can try this out :-)