Skip to content

update minimum version of cmake now that version 3.5 of cmake has been deprecated #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

update minimum version of cmake now that version 3.5 of cmake has been deprecated #632

wants to merge 3 commits into from

Conversation

NissimBendanan
Copy link
Contributor

No description provided.

@NissimBendanan
Update CMakeLists.txt
2b7db7a 
update minimum version of cmake now that version 3.5 of cmake has been deprecated
@NissimBendanan
Merge pull request #1 from NissimBendanan/update_minimum_cmake_version
ad817ed 
Update CMakeLists.txt
@probonopd
Copy link
Owner

Why would we ever want to do that? I think it is good that our software still builds using older build systems.

@probonopd probonopd closed this Mar 31, 2025
@NissimBendanan
Copy link
Contributor Author

NissimBendanan commented Apr 1, 2025 via email

@NissimBendanan
Copy link
Contributor Author

NissimBendanan commented Apr 1, 2025 •
edited
Loading

this is the cmake config error with cmake_minimum_required(VERSION 3.2):

[cmake] CMake Error at vendor/github.com/probonopd/linuxdeployqt/CMakeLists.txt:4 (cmake_minimum_required):
[cmake] Compatibility with CMake < 3.5 has been removed from CMake.
[cmake]
[cmake] Update the VERSION argument value. Or, use the ... syntax

even after my change to update to the minimum version supported by cmake (currently 3.5), we don't get an error but a warning:

[cmake] CMake Deprecation Warning at vendor/github.com/probonopd/linuxdeployqt/CMakeLists.txt:4 (cmake_minimum_required):
[cmake] Compatibility with CMake < 3.10 will be removed from a future version of
[cmake] CMake.
[cmake]
[cmake] Update the VERSION argument value. Or, use the ... syntax
[cmake] to tell CMake that the project requires at least but has been updated
[cmake] to work with policies introduced by or earlier.

So, the latest version of cmake 4.0.0. no longer supports versions earlier than 3.5

@alzix
Copy link

alzix commented Apr 1, 2025

GitHub actions ubuntu runner was recently updated to include CMake version 4.0.0 - see https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20250330.1
This PR fixes the compilation error caused by a compatibility issue with the new CMake version.

Why would we ever want to do that?

You must decide whether to support legacy CMake versions or newer versions. The majority of developers will have a newer version of CMake installed.
Notice the change set minimum required version to 3.5 released in 2018. But the warning says it will be removed soon as well.
| suggest setting it to 3.10 right now

@probonopd probonopd reopened this Apr 1, 2025
@NissimBendanan
Update CMakeLists.txt
b095ea5 
update minimum version of cmake to 3.10
- version < 3.5 have been deprecated
- version < 3.10 will be next removed
@probonopd
Copy link
Owner

Closing in favor of #633

@probonopd probonopd closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NissimBendanan @probonopd @alzix