Fix keyboard navigation for various settings#3474
Conversation
|
@Jatin24062005 Can you review this PR please. |
|
@yugalkaushik I’ve reviewed your pull request and tested it on my machine. I noticed a couple of issues: the keyboard navigation currently allows focusing only on enabled buttons, but it should also allow navigation to disabled buttons like Similar to the High Contrast and Dark theme options. Additionally, the focus border appears slightly thicker than the standard one, which creates inconsistency in the UI. Please look into these issues and make the necessary adjustments. |
|
|
@raclim can you please review. |
raclim
left a comment
There was a problem hiding this comment.
Thanks so much for your work on this!
After testing this out, I think this is overall a positive change and would be great to have out. We could definitely add any needed adjustments here in the future!


Fixes #3448
Changes:
general.setting.mp4
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123