Fix: use async bcrypt in findMatchingKey #3878#3897
Open
Nixxx19 wants to merge 1 commit intoprocessing:developfrom
Open
Fix: use async bcrypt in findMatchingKey #3878#3897Nixxx19 wants to merge 1 commit intoprocessing:developfrom
Nixxx19 wants to merge 1 commit intoprocessing:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3878
Changes
Replaced
bcrypt.compareSync()withbcrypt.compare()in thefindMatchingKeymethod to prevent blocking the Node.js event loop during API key authentication.Before:
bcrypt.compareSync()which blocks the event loopawaiton a boolean return value had no effectAfter:
bcrypt.compare()which returns a PromiseWhy this is better:
bcrypt.compare()runs asynchronously, so API key verification no longer blocks the Node.js event loop during hash comparisonsawaitnow waits on a real Promise instead of a boolean, matching the intent of theasyncmethod signatureI have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #3878