Skip to content

Conversation

@rakesh2OO5
Copy link

Summary

Fixes incorrect source links on p5.sound reference pages that were pointing to the p5.js repository and resulting in 404 errors.

Details

  • Detects when a reference entry belongs to the p5.sound module
  • Routes source links to the processing/p5.sound.js repository
  • Uses main branch for p5.sound and versioned tags for p5.js
  • Keeps existing UI behavior unchanged

Result

Source links on p5.sound reference pages now correctly resolve to valid GitHub files instead of returning 404 errors.

Fixes #1030

@rakesh2OO5
Copy link
Author

This PR contains the updated fix addressing the review feedback from #1073.

p5.sound links now point to processing/p5.sound.js (main branch)

p5.js links remain versioned

No UI behavior changed

Supersedes #1073.

@rakesh2OO5
Copy link
Author

I’ve added screenshots below to demonstrate the expected behavior after the fix.

The “Edit this file” link on p5.sound reference pages now correctly resolves to the processing/p5.sound.js repository (main branch) and no longer returns 404s.

Please let me know if any additional verification is needed.
Screenshot 2026-01-05 175651
Screenshot 2026-01-05 175615

Copy link
Collaborator

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@davepagurek davepagurek merged commit d671cb3 into processing:2.0 Jan 11, 2026
4 checks passed
@davepagurek
Copy link
Collaborator

@all-contributors please add @rakesh2OO5 for code

@rakesh2OO5 rakesh2OO5 deleted the 2.0 branch January 11, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants