Fix search clear button not resetting search state #1078
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perminder-17
approved these changes
Jan 6, 2026
Contributor
perminder-17
left a comment
perminder-17
left a comment
There was a problem hiding this comment.
Works well and looks good to me! Thanks for the fix
Contributor
|
Are you also interested in fixing that in |
Contributor
Author
|
Yes, I'll fix the same in 2.0 branch |
Contributor
Author
|
@perminder-17 I have raised a PR and applied the same changes to branch 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #949
Previous Behavior
When users clicked the X to clear the search input, the visual field was cleared but the search state in the parent component remained unchanged. This caused old search results to reappear when typing again.
Solution
Updated clearInput() to call onSearchChange("") so the parent component's search state is properly reset along with the input field.