Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

重写了'补全实现',获得vsc本身的提示并翻译为拼音. #20

Merged
merged 9 commits into from
Jun 27, 2020

Conversation

lsby
Copy link
Collaborator

@lsby lsby commented Jun 26, 2020

另外引入了.editorconfig文件,并对全部文件进行了格式化.
如果您不能接受如此大范围的修改.可以只采用补全实现.js文件.

QQ截图20200626225257
QQ截图20200626225311
QQ截图20200626225324

.editorconfig Outdated Show resolved Hide resolved
@nobodxbodon
Copy link
Member

看了两个格式化的 commit (f24446e590ab3d )感觉挺好没啥问题,只有一处疑问

@nobodxbodon
Copy link
Member

可否将截图所示的测试小用例添加到测试目录

"runtimeExecutable": "${execPath}",
"args": [
"--extensionDevelopmentPath=${workspaceFolder}",
"--disable-extensions"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个新加的 disable 需要注释掉吗?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个新加的功能是,在调试的时候关闭其他扩展,可以在调试的时候避免其他扩展的干扰,我觉得挺ok的,你考虑一下?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦,这个只在本地f5 运行的时候有效是吧?那 ok~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦,这个只在本地f5运行的时候有效是吧?

对的对的

@nobodxbodon
Copy link
Member

@zj1d 可否审阅一下 04e536e ?好像提示生成逻辑改动蛮大。

@nobodxbodon nobodxbodon requested a review from zj1d June 26, 2020 23:48
@lsby
Copy link
Collaborator Author

lsby commented Jun 27, 2020

否将截图所示的测试小用

已添加

Copy link
Collaborator

@zj1d zj1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

妙啊

@zj1d zj1d merged commit 6e1041b into program-in-chinese:master Jun 27, 2020
@nobodxbodon
Copy link
Member

刚测了几个首页例子,发现以下不同:

  1. PHP 好像没补全:
    Screen Shot 2020-06-26 at 8 21 17 PM
  2. 有几个拼音需要多输入一点点:
    python:
    Screen Shot 2020-06-26 at 6 19 59 PM
    swift:
    Screen Shot 2020-06-26 at 6 19 32 PM

@lsby
Copy link
Collaborator Author

lsby commented Jun 27, 2020

@nobodxbodon
1 确实是存在的,又提了一个pr #21 ,另外php要安装php的其他插件才能有自动补全.
2 这应该是vsc的机制 有时候会慢一点?
QQ截图20200627120024

@nobodxbodon
Copy link
Member

2 的这个斐波那契的例子大概是因为我有些自定义的 snippet:
Screen Shot 2020-06-26 at 10 21 14 PM

@lsby
Copy link
Collaborator Author

lsby commented Jun 27, 2020

2的这个斐波那契的例子大概是因为我有些自定义的snippet:
屏幕快照2020-06-26在10 21 14 PM

如何设置这个自定义片段呢

@nobodxbodon
Copy link
Member

@lsby program-in-chinese/overview#133 一楼有些说明,不过感觉 2 的问题不大,暂时不必深究哈。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants