Update Anope. #248
Merged
Update Anope. #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah it seems like I need to update the Anope controller to use the new linking protocol names. I'll look into that now. |
progval
reviewed
Jan 4, 2024
| assert services_path | ||
|
|
||
| # Config and code need to be in the same directory, *obviously* | ||
| (self.directory / "lib").symlink_to(Path(services_path).parent.parent / "lib") | ||
|
|
||
| self.proc = subprocess.Popen( | ||
| [ | ||
| "services", | ||
| "anope", |
progval
reviewed
Jan 4, 2024
Comment on lines
+346
to
+349
| stable: "2.0.14" | ||
| release: "2.1.1" | ||
| devel: "2.1" | ||
| devel_release: "2.0" |
It seemed to pass the CI this way, do you mean it is going to be an issue for other versions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also switched it to building with Ninja as that builds a lot faster.