Skip to content

Commit

Permalink
review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
wqx6 committed Nov 18, 2024
1 parent a402601 commit 969f93f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,10 @@ void CodegenDataModelProvider::Temporary_ReportAttributeChanged(const AttributeP
}
else
{
// If cluster Id is invalid, mark the endpoint dirty using the path. This can happen when enabling/disabling the endpoint.
change_listener.MarkDirty(path);
// When the path has wildcard cluster Id, call the emberAfEndpointChanged to mark attributes on the given endpoint
// as having changing, but do NOT increase/alter any cluster data versions, as this happens when a bridged endpoint is
// added or removed from a bridge and the cluster data is not changed during the process.
emberAfEndpointChanged(path.mEndpointId, &change_listener);
}
}

Expand Down
5 changes: 5 additions & 0 deletions src/app/util/mock/attribute-storage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,11 @@ void emberAfAttributeChanged(EndpointId endpoint, ClusterId clusterId, Attribute
listener->MarkDirty(AttributePathParams(endpoint, clusterId, attributeId));
}

void emberAfEndpointChanged(EndpointId endpoint, AttributesChangedListener *listener)
{
listener->MarkDirty(AttributePathParams(endpoint));
}

unsigned emberAfMetadataStructureGeneration()
{
return metadataStructureGeneration;
Expand Down

0 comments on commit 969f93f

Please sign in to comment.