Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Device Energy Management Mode Cluster] Device Energy Management Mode Cluster XML has to be updated as per Spec #36059

Closed
2 tasks
Ashwinigrl opened this issue Oct 14, 2024 · 3 comments · Fixed by #36155
Labels
bug Something isn't working energy DEM energy needs triage spec Mismatch between spec and implementation v1.4

Comments

@Ashwinigrl
Copy link

Ashwinigrl commented Oct 14, 2024

Description:

  • 1. Below following Feature and Attributes are Disallowed for the Device Energy Management Mode Cluster. So these should be removed from the Device Energy Management Mode Cluster device XML.

Feature:

  1. OnOff

Attributes:

  1. StartUpMode
  2. OnMode

Spec Reference:

image

image

XML References:

image

image

  • 2. In Spec, Device Energy Management Mode Cluster Revision value has been updated from 1 to 2. So XML has to be updated as per the spec.

Spec Reference:

image

XML References:

image

@cecille
Copy link
Contributor

cecille commented Oct 16, 2024

Data model XMLs are updated automatically and aligned to spec tags. These data model XMLs will be updated when the spec tag for the board release is tagged.
These data model files are automatically generated and should not be updated by hand.

They don't need individual issues opened.

Closing this as it will be fixed once the spec is properly tagged and I don't want anyone thinking they need to make hand edits.

@bzbarsky-apple
Copy link
Contributor

Data model XMLs are updated automatically and aligned to spec tags

This is not about data model XMLs, which are under /data_model. This is about a file under /src/app/zap-templates/zcl/data-model/chip.

@jamesharrow
Copy link
Contributor

PR here to fix: #36155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working energy DEM energy needs triage spec Mismatch between spec and implementation v1.4
Projects
Archived in project
4 participants