Remove provisional (and disallowed by the device type) attribtes from… #29015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the derivations of Mode Base for: - Refrigerator - Laundry Washer - Dishwasher Tests: - Regen all - build all - build chip-tool and all-clusters - via chip-tool, pair all-clusters and read the attribute list from the affected clusters
|
PR #29015: Size comparison from 5deb59b to 44bf76e Decreases (21 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 1, 2023
|
PR #29015: Size comparison from 5deb59b to 7eb5818 Increases (3 builds for linux)
Decreases (21 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
arkq,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
|
PR #29015: Size comparison from 09bb8d2 to ac48bae Increases above 0.2%:
Increases (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, k32w, qpg)
Decreases (16 builds for bl702, bl702l, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #29015: Size comparison from 09bb8d2 to e0d232f Increases above 0.2%:
Increases (21 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, k32w, linux, qpg)
Decreases (20 builds for bl702, bl702l, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
all cases even though they were optional (and now provisional).
|
PR #29015: Size comparison from 09bb8d2 to 5074f8c Increases above 0.2%:
Increases (21 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, k32w, linux, qpg)
Decreases (22 builds for bl702, bl702l, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #29015: Size comparison from bc9f42e to 8904b45 Increases (2 builds for bl702, esp32)
Decreases (24 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #29015: Size comparison from 188cf7d to 888f79a Decreases (15 builds for bl702, bl702l, cc32xx, linux, nrfconnect, psoc6)
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #29015: Size comparison from 188cf7d to e67a53d Increases above 0.2%:
Increases (18 builds for esp32, telink)
Decreases (38 builds for bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
added
the
skip-protocol-compatibility
|
PR #29015: Size comparison from 1e03c08 to 4d4c7e3 Increases (2 builds for bl702, esp32)
Decreases (22 builds for bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
PR has conflicts and has not been updated in a long time (even though it has sufficient checkmarks). Assuming stale and closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the derivations of Mode Base for:
Tests:
See issue: #26746