-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Media::AccountLogin cluster to match the spec #29944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set "nullable" attribute to setup pin on reply for getting the setup pin - mark the Login and GetSetupPin requiring administer privileges.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
October 24, 2023 14:21
PR #29944: Size comparison from f74e95b to e985183 Increases above 0.2%:
Increases (19 builds for bl702, bl702l, cc32xx, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
commented
Oct 24, 2023
examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
Outdated
Show resolved
Hide resolved
bzbarsky-apple
previously requested changes
Oct 24, 2023
examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
Outdated
Show resolved
Hide resolved
PR #29944: Size comparison from a16d6e9 to 21a4dd9 Increases (1 build for nrfconnect)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
andy31415
dismissed
bzbarsky-apple’s stale review
October 30, 2023 18:45
Removed the wire incompat change and moved to spec PR. Still need to determine about fabric commands.
PR #29944: Size comparison from a16d6e9 to 33b1676 Increases (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (2 builds for linux)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
examples/tv-app/tv-common/clusters/account-login/AccountLoginManager.cpp
Outdated
Show resolved
Hide resolved
PR #29944: Size comparison from a16d6e9 to db08c7a Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 31, 2023
PR #29944: Size comparison from 0db7c58 to 2ef4fbc Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
examples
fast track
review - approved
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Changes to be made in spec: