Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TC-VALCC-4.2: unconditionally write open duration #35852

Merged
merged 4 commits into from
Oct 9, 2024
Merged

TC-VALCC-4.2: unconditionally write open duration #35852

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba7c499
TC-VALCC-4.2: unconditionally write open duration
cecille Sep 28, 2024
88b1f8d
linter
cecille Oct 7, 2024
97b6ba2
Update src/python_testing/TC_VALCC_4_2.py
andy31415 Oct 8, 2024
6644fbd
Update src/python_testing/TC_VALCC_4_2.py
andy31415 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/python_testing/TC_VALCC_4_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
# test-runner-run/run1/script-args: --storage-path admin_storage.json --commissioning-method on-network --discriminator 1234 --passcode 20202021 --trace-to json:${TRACE_TEST_JSON}.json --trace-to perfetto:${TRACE_TEST_PERFETTO}.perfetto
# === END CI TEST ARGUMENTS ===

import logging
import time

import chip.clusters as Clusters
Expand Down Expand Up @@ -55,6 +54,7 @@ def steps_TC_VALCC_4_2(self) -> list[TestStep]:
TestStep(8, "Send Close command"),
TestStep(9, "Read OpenDuration attribute"),
TestStep(10, "Read RemainingDuration attribute"),
TestStep(11, "Write DefaultOpenDuration back to original value")
]
return steps

Expand All @@ -73,16 +73,11 @@ async def test_TC_VALCC_4_2(self):
attributes = Clusters.ValveConfigurationAndControl.Attributes

self.step("2a")
defaultOpenDuration = await self.read_valcc_attribute_expect_success(endpoint=endpoint, attribute=attributes.DefaultOpenDuration)
originalDefaultOpenDuration = await self.read_valcc_attribute_expect_success(endpoint=endpoint, attribute=attributes.DefaultOpenDuration)

self.step("2b")
if defaultOpenDuration is NullValue:
defaultOpenDuration = 60

result = await self.default_controller.WriteAttribute(self.dut_node_id, [(endpoint, attributes.DefaultOpenDuration(defaultOpenDuration))])
asserts.assert_equal(result[0].Status, Status.Success, "DefaultOpenDuration write failed")
else:
logging.info("Test step skipped")
defaultOpenDuration = 60
await self.write_single_attribute(attributes.DefaultOpenDuration(defaultOpenDuration))
andy31415 marked this conversation as resolved.
Show resolved Hide resolved

self.step(3)
try:
Expand Down Expand Up @@ -129,6 +124,9 @@ async def test_TC_VALCC_4_2(self):
remaining_duration_dut = await self.read_valcc_attribute_expect_success(endpoint=endpoint, attribute=attributes.RemainingDuration)
asserts.assert_true(remaining_duration_dut is NullValue, "RemainingDuration is not null")

self.step(11)
await self.write_single_attribute(attributes.DefaultOpenDuration(originalDefaultOpenDuration))
andy31415 marked this conversation as resolved.
Show resolved Hide resolved


if __name__ == "__main__":
default_matter_test_main()
Loading