[Fabric-Sync] Use aggregator endpoint instead of root endpoint for CCTRL #35977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 3 of 10 files. Overall, the semantic diff is 5% smaller than the GitHub diff.
|
|
PR #35977: Size comparison from 0a2e58d to 3d0620f Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/fs/endpoint
branch
from
3d0620f
to
544fc7f
Compare
|
PR #35977: Size comparison from a854245 to 544fc7f Full report (22 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
yufengwangca
force-pushed
the
pr/fs/endpoint
branch
from
544fc7f
to
f03e0ed
Compare
github-actions
bot
added
tests
matter-1.4-te2-script-change
yufengwangca
force-pushed
the
pr/fs/endpoint
branch
2 times, most recently
from
0bf1dd0
to
325b950
Compare
|
PR #35977: Size comparison from a854245 to 325b950 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/fs/endpoint
branch
from
325b950
to
1cbef43
Compare
|
PR #35977: Size comparison from a854245 to 1cbef43 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/fs/endpoint
branch
from
1cbef43
to
837e6b8
Compare
|
PR #35977: Size comparison from af3727b to 837e6b8 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Oct 9, 2024
tehampson
reviewed
Oct 9, 2024
tehampson
reviewed
Oct 9, 2024
|
PR #35977: Size comparison from af3727b to f6f23e3 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 10, 2024
tehampson
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest update to the FS system diagram in the specification, it is now explicitly required that CCTRL be enabled on the endpoint hosting the aggregator.
CCTRL is a feature of the Aggregator device type when FS is enabled and must be activated on the corresponding endpoint.
In the example apps, the Aggregator is statically configured on Endpoint 1 using zap, and the Aggregator endpoint is statically set. The next optimization should enable the Fabric-Admin to dynamically identify the endpoint hosting the aggregator at runtime. (#35976)