[Darwin] Implemented download diagnostics log for MTRDevice_XPC #35998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anush-apple
commented
Oct 9, 2024
anush-apple
commented
- Implemented the downloadLogOfType API on MTRDevice_XPC to call into XPC server to forward the request
- Fixed the protocol to take controllerID which is missing from existing protocol
- Implemented the downloadLogOfType API on MTRDevice_XPC to call into XPC server to forward the request - Fixed the protocol to take controllerID which is missing from existing protocol
|
Review changes with SemanticDiff. |
|
PR #35998: Size comparison from 6252541 to 96eae59 Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
woody-apple
approved these changes
Oct 9, 2024
|
PR #35998: Size comparison from 6252541 to a1d534e Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
reviewed
Oct 9, 2024
|
PR #35998: Size comparison from 6252541 to 5ca1a95 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35998: Size comparison from 6252541 to 342eac6 Increases above 0.2%:
Full report (78 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Oct 10, 2024
andy31415
approved these changes
Oct 10, 2024
| /* Note: The consumer of the completion block should move the file that the url points to or open it for reading before the | ||
| * completion handler returns. Otherwise, the file will be deleted, and the data will be lost. | ||
| */ | ||
| - (oneway void)deviceController:(NSUUID *)controller nodeID:(NSNumber *)nodeID downloadLogOfType:(MTRDiagnosticLogType)type timeout:(NSTimeInterval)timeout completion:(void (^)(NSURL * _Nullable url, NSError * _Nullable error))completion; |
There was a problem hiding this comment.
The comments here do not seem to match the code. The code is doing an explicit remove, no? Why does it need to do that if the file will be deleted automatically?
Or am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.