[Python] revert unnecessary reformat #36094
Open
+38
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dcb4444.
This reimplements project-chip#32257 without reformatting Python files.
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 100% smaller than the GitHub diff. 1 files do not contain logic changes.
|
|
PR #36094: Size comparison from 579b1b1 to 498da00 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
I think that the proper solution for that would be to "somehow" add python formatting to restyled and enforce it during PR. Otherwise, everyone will format the code to their likeness - which introduces unnecessary noise in the code and bloats repo size. I'm not going to mark it as requested changes, but please consider to add codestyle (whatever the codestyle is, IMHO it would be better to have some random and consistent one than noting at all) check to CI. |
andy31415
approved these changes
Oct 16, 2024
We do run autopep8 as part of the pipeline, however, it seems that autopep8 only makes sure that lines are shorter than x, and does not reformat if lines got shortened. Introducing a more forceful approach to formatting probably would introduce quite some change at first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Python line length of 132 characters. This reverts unnecessary reformat introduced by #32257.
For easier review, this has been implemented with two commits, one which simply reverts #32257, and the second which implements the actual change again.
This has been cross-validated by reformatting with
autopep8default line length, the effective change ends up to be exactly the same.