[darwin] Update the NetworkFramework UDP implementation #36418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
Darwin_NetworkFrameworkUpdate
branch
from
044c7b2
to
9b05890
Compare
|
PR #36418: Size comparison from 4edae20 to 9b05890 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
For reviewers: I tried to |
vivien-apple
force-pushed
the
Darwin_NetworkFrameworkUpdate
branch
from
9b05890
to
b347675
Compare
|
PR #36418: Size comparison from 4edae20 to b347675 Full report (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink)
|
vivien-apple
force-pushed
the
Darwin_NetworkFrameworkUpdate
branch
from
b347675
to
e8d37ab
Compare
|
PR #36418: Size comparison from 9961bb8 to e8d37ab Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Nov 8, 2024
woody-apple
reviewed
Nov 11, 2024
…HIP_CONFIG_IsPlatformPOSIXErrorNonCritical
…HIP_SYSTEM_CONFIG_USE_POSIX_SOCKETS
…ditional #ifdef for the network framework
…onal #ifdef for the network framework
…nable the default implementation
…n using the network framework
…m with arc support
…ce Network.framework won't allow SO_REUSEPORT
…network_framework flag support
vivien-apple
force-pushed
the
Darwin_NetworkFrameworkUpdate
branch
from
e8d37ab
to
ee2ba6b
Compare
bzbarsky-apple
approved these changes
Nov 14, 2024
jmartinez-silabs
approved these changes
Nov 14, 2024
|
PR #36418: Size comparison from 9a68d62 to 2173536 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
NetworkFrameworkimplementation has been broken by multiple changes.This PR updates the various
#ifdefsflags to make it possible to compile it again. It also adds achip_system_config_use_network_frameworkbuild flag and convert the implementation from.cppto.mmwithARCenabled.