Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera AVStreamMgmt SDK changes for spec updates #36447

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Camera AVStreamMgmt SDK changes for spec updates #36447

merged 2 commits into from
Nov 12, 2024

Conversation

pidarped
Copy link
Contributor

Incorporate Spec updates to CameraAVStreamMgmt cluster
- Use Alchemy to re-generate the xml.
- Add feature tag to attributes and commands.
- Remove SetViewport and ImageRotation commands.

@pidarped
Incorporate Spec updates to CameraAVStreamMgmt cluster
fdbc501 
- Use Alchemy to re-generate the xml.
- Add feature tag to attributes and commands.
- Remove SetViewport and ImageRotation commands.
@pidarped pidarped requested review from a team as code owners November 10, 2024 07:51
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 10, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/controller/java/generated/java/chip/devicecontroller/ClusterIDMapping.java  21% smaller
  src/controller/python/chip/clusters/Objects.py  15% smaller
  src/controller/java/generated/java/chip/devicecontroller/ClusterWriteMapping.java  12% smaller
  src/app/zap-templates/zcl/data-model/chip/camera-av-stream-management-cluster.xml Unsupported file format
  src/controller/data_model/controller-clusters.matter Unsupported file format
  src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java Unsupported file format
  src/controller/java/generated/java/chip/devicecontroller/ClusterInfoMapping.java  0% smaller
  src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java  0% smaller
  src/controller/java/generated/java/matter/controller/cluster/clusters/CameraAvStreamManagementCluster.kt Unsupported file format
  src/controller/java/zap-generated/CHIPAttributeTLVValueDecoder.cpp Unsupported file format
  src/controller/python/chip/clusters/CHIPClusters.py  0% smaller
  src/darwin/Framework/CHIP/zap-generated/MTRAttributeSpecifiedCheck.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRAttributeTLVValueDecoder.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRClusterNames.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRClusters.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRClusters.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloadsObjc.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloadsObjc.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloads_Internal.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/callback.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/cluster-enums.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/cluster-objects.cpp Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/cluster-objects.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/ids/Attributes.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/ids/Commands.h Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/Commands.h Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/logging/EntryToText.cpp Unsupported file format
  zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h Unsupported file format

@pidarped pidarped changed the title Camera av stream mgmt SDK changes for spec updates Camera AVStreamMgmt SDK changes for spec updates Nov 10, 2024
@github-actions GitHub Actions
Copy link

PR #36447: Size comparison from c3b35eb to b3182c3

Full report (1 build for stm32)
platform target config section c3b35eb b3182c3 change % change
stm32 light STM32WB5MM-DK FLASH 482920 482920 0 0.0
RAM 144844 144844 0 0.0

@pidarped pidarped force-pushed the CameraAVStreamMgmtSpecUpdates branch from b3182c3 to 7d76f2a Compare November 10, 2024 22:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2024 •
edited
Loading

PR #36447: Size comparison from c3b35eb to 7d76f2a

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c3b35eb 7d76f2a change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349404 1349404 0 0.0
RAM 104080 104080 0 0.0
bl702 lighting-app bl702+eth FLASH 649330 649330 0 0.0
RAM 25321 25321 0 0.0
bl702+wifi FLASH 826910 826910 0 0.0
RAM 14053 14053 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055108 1055108 0 0.0
RAM 23893 23893 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 976474 976474 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837828 837828 0 0.0
RAM 123628 123628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823736 823736 0 0.0
RAM 125516 125516 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770468 770468 0 0.0
RAM 113984 113984 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754680 754680 0 0.0
RAM 114192 114192 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 625902 625902 0 0.0
RAM 205780 205780 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667214 667214 0 0.0
RAM 205932 205932 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679473 679473 0 0.0
RAM 78684 78684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699317 699317 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699317 699317 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656253 656253 0 0.0
RAM 73752 73752 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616321 616321 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635957 635957 0 0.0
RAM 74188 74188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635957 635957 0 0.0
RAM 74188 74188 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635777 635777 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655485 655485 0 0.0
RAM 77236 77236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655485 655485 0 0.0
RAM 77236 77236 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611173 611173 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631025 631025 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631025 631025 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 927564 927564 0 0.0
RAM 160160 160160 0 0.0
BRD4338a FLASH 743680 743680 0 0.0
RAM 233288 233288 0 0.0
window-app BRD4187C FLASH 1018784 1018776 -8 -0.0
RAM 128260 128260 0 0.0
esp32 all-clusters-app c3devkit DRAM 95328 95328 0 0.0
FLASH 1540416 1540416 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116256 116256 0 0.0
FLASH 1549266 1549254 -12 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4712 4712 0 0.0
FLASH 2698929 2698929 0 0.0
RAM 129648 129648 0 0.0
all-clusters-app debug unknown 5552 5552 0 0.0
FLASH 5992626 5992466 -160 -0.0
RAM 523968 523520 -448 -0.1
all-clusters-minimal-app debug unknown 5448 5448 0 0.0
FLASH 5328234 5328234 0 0.0
RAM 242480 242480 0 0.0
bridge-app debug unknown 5432 5432 0 0.0
FLASH 4671004 4671004 0 0.0
RAM 218416 218416 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 12872224 12854044 -18180 -0.1
RAM 584466 583122 -1344 -0.2
chip-tool-ipv6only arm64 unknown 21400 21336 -64 -0.3
FLASH 11002736 10988976 -13760 -0.1
RAM 635368 634024 -1344 -0.2
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11277331 11260215 -17116 -0.2
RAM 584818 583474 -1344 -0.2
fabric-bridge-app debug unknown 4688 4688 0 0.0
FLASH 4495274 4495274 0 0.0
RAM 205392 205392 0 0.0
fabric-sync debug unknown 4896 4896 0 0.0
FLASH 5309749 5309589 -160 -0.0
RAM 466872 466424 -448 -0.1
lighting-app debug+rpc+ui unknown 6096 6096 0 0.0
FLASH 5606929 5606929 0 0.0
RAM 228552 228552 0 0.0
lock-app debug unknown 5368 5368 0 0.0
FLASH 4720478 4720478 0 0.0
RAM 204552 204552 0 0.0
ota-provider-app debug unknown 4744 4744 0 0.0
FLASH 4345910 4345910 0 0.0
RAM 198272 198272 0 0.0
ota-requestor-app debug unknown 4680 4680 0 0.0
FLASH 4484312 4484312 0 0.0
RAM 202840 202840 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 3011325 3011325 0 0.0
RAM 160368 160368 0 0.0
thermostat-no-ble arm64 unknown 9440 9440 0 0.0
FLASH 4090000 4090000 0 0.0
RAM 242936 242936 0 0.0
tv-app debug unknown 5664 5664 0 0.0
FLASH 5943701 5943541 -160 -0.0
RAM 596336 595888 -448 -0.1
tv-casting-app debug unknown 5232 5232 0 0.0
FLASH 11079421 11060509 -18912 -0.2
RAM 694536 693000 -1536 -0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915308 915308 0 0.0
RAM 143281 143281 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 887568 887568 0 0.0
RAM 141468 141468 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847564 847564 0 0.0
RAM 142189 142189 0 0.0
nxp contact k32w0+release FLASH 584096 584096 0 0.0
RAM 71044 71044 0 0.0
mcxw71+release FLASH 598640 598640 0 0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 611156 611156 0 0.0
RAM 70436 70436 0 0.0
k32w1+release FLASH 684952 684952 0 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 748488 748488 0 0.0
RAM 67300 67300 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1642948 1642948 0 0.0
RAM 212056 212056 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550164 1550164 0 0.0
RAM 208856 208856 0 0.0
light cy8ckit_062s2_43012 FLASH 1466588 1466588 0 0.0
RAM 200840 200840 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464764 1464764 0 0.0
RAM 225200 225200 0 0.0
qpg lighting-app qpg6105+debug FLASH 662120 662120 0 0.0
RAM 105380 105380 0 0.0
lock-app qpg6105+debug FLASH 620220 620220 0 0.0
RAM 99832 99832 0 0.0
stm32 light STM32WB5MM-DK FLASH 482920 482920 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 684642 684642 0 0.0
RAM 91528 91528 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622654 622654 0 0.0
RAM 50464 50464 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710580 710580 0 0.0
RAM 73804 73804 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628948 628948 0 0.0
RAM 145384 145384 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814836 814836 0 0.0
RAM 100004 100004 0 0.0
tizen all-clusters-app arm unknown 4948 4948 0 0.0
FLASH 1722468 1722468 0 0.0
RAM 90656 90656 0 0.0
chip-tool-ubsan arm unknown 10832 10800 -32 -0.3
FLASH 18006294 17979638 -26656 -0.1
RAM 7857036 7844172 -12864 -0.2

@mergify mergify bot merged commit ebfd212 into project-chip:master Nov 12, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@aronrosenberg aronrosenberg aronrosenberg approved these changes

Assignees
No one assigned
Labels
app controller darwin review - approved
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pidarped @aronrosenberg @yufengwangca