Handle ACL and readability in reporting/Engine.cpp
#36488
+74
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36488: Size comparison from 45a75ba to 1df0e39 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
andy31415
commented
Nov 13, 2024
|
PR #36488: Size comparison from 45a75ba to 122a60c Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36488: Size comparison from 45a75ba to 7bab9a7 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Nov 15, 2024
| /// Returns the status of ACL validation. | ||
| /// if the status is set, the status is FINAL (i.e. permanent failure OR success due to path expansion logic.) | ||
| /// if the status is not set, the processing can continue | ||
| std::optional<CHIP_ERROR> ValidateReadACL(DataModel::Provider * dataModel, const Access::SubjectDescriptor & subjectDescriptor, |
There was a problem hiding this comment.
Suggested change
| std::optional<CHIP_ERROR> ValidateReadACL(DataModel::Provider * dataModel, const Access::SubjectDescriptor & subjectDescriptor, | |
| std::optional<CHIP_ERROR> ValidateReadAttributeACL(DataModel::Provider * dataModel, const Access::SubjectDescriptor & subjectDescriptor, |
|
|
||
| std::optional<DataModel::AttributeInfo> info = dataModel->GetAttributeInfo(path); | ||
|
|
||
| chip::Access::Privilege requiredPrivilege = chip::Access::Privilege::kView; // default |
There was a problem hiding this comment.
Why all the extra chip:: prefixes?
| chip::Access::Privilege requiredPrivilege = chip::Access::Privilege::kView; // default | ||
| if (info.has_value() && info->readPrivilege.has_value()) | ||
| { | ||
| // set a default even if we do not know and later report the real error if ACL looks ok |
There was a problem hiding this comment.
I don't understand what this comment is trying to say.
| return std::nullopt; | ||
| } | ||
|
|
||
| // attribute does not exist, however we do not now if this is a unsupported endpoint, cluster or attribute, |
There was a problem hiding this comment.
Why does attribute not exist? All we know is we did an access check and it succeeeded.
This code is not making any sense to me. Stopping here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #36484: move the ACL validation out of
DataModel::Provider::ReadAttributeand have this handled by the interaction model reporting engine based on the metadata passed in by the provider.