List all NetworkCommissioning cluster attributes in zcl.json and zcl-with-test-extensions.json #36516
+4,000
−13,311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementation. List in in the zcl json
jmartinez-silabs
changed the title
lpbeliveau-silabs
approved these changes
Nov 15, 2024
| "Network Commissioning": [ | ||
| "MaxNetworks", | ||
| "Networks", | ||
| "ScanMaxTimeSeconds", |
There was a problem hiding this comment.
The implementation sometimes falls through for ScanMaxTimeSeconds, so it's not always handled via AttributeAccessInterface. Can't add it here until it is.
| "MaxNetworks", | ||
| "Networks", | ||
| "ScanMaxTimeSeconds", | ||
| "ConnectMaxTimeSeconds", |
There was a problem hiding this comment.
Likewise: this is not always handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All attributes of the network commissioning cluster are from external implementations.
List all of them in :
so they aren't exposed in zap as configurable
for review, Commit 1 : update the JSON files
commit 2 is the regen that update all .zap and .matter