Chef: Add APIs to provide deviceType info on Endpoints. Make chef static temperature levels (temperature control cluster) endpoint agnostic. #38142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on initialization in attribute storage.
|
PR #38142: Size comparison from 4616f83 to dc03344 Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38142: Size comparison from 4616f83 to e528154 Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38142: Size comparison from 0e08ff1 to 2bb9099 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #38142: Size comparison from 0e08ff1 to cdb5c3b Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38142: Size comparison from 0e08ff1 to c348009 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38142: Size comparison from 0e08ff1 to dd544d4 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/chef/common/clusters/temperature-control/static-supported-temperature-levels.cpp
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Apr 4, 2025
|
PR #38142: Size comparison from 9dafec6 to b204b5e Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
19 tasks
bzbarsky-apple
dismissed
their stale review
Relevant code is no longer in this PR.
|
fast tracking chef-only fixes |
|
PR #38142: Size comparison from 625d0e7 to 7336521 Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38142: Size comparison from da0c5ad to b0dd140 Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Apr 11, 2025
| { | ||
| if (EndpointHasDeviceType(ep.id, deviceTypeId)) | ||
| { | ||
| endpoints.Append(ep.id); |
There was a problem hiding this comment.
Post-merge review because #38364 noticed this:
- we ignore CHIP_ERROR return here
- Append requires a capacity reserve otherwise it does not work
andy31415
reviewed
Apr 11, 2025
| return false; | ||
| } | ||
|
|
||
| DataModel::ListBuilder<EndpointId> DeviceTypes::GetAllEndpointsHavingDeviceType(DeviceTypeId deviceTypeId) |
There was a problem hiding this comment.
post merge review, also fixed in followup: this should return the data, not a builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary -
Testing
Tested with oven device from PR: #38108
src/python_testing/TC_DeviceBasicComposition.py on oven device.