Skip to content

Conversation

jungwook-park
Copy link
Contributor

Summary

  • Updated the webOS Platform's Wifi service and handling logic to meet the Matter 1.5 Spec
  • Maintained backward compatibility with existing Matter 1.1 code

Related issues

N/A(because owning a webOS Platform)

Testing

Manually tested well on webOS TV

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

  • [O] PR title is
    descriptive
  • [O] Apply the
    “When in Rome…”
    rule (coding style)
  • [O] PR size is short
  • [O] Try to avoid "squashing" and "force-update" in commit history
  • [O] CI time didn't increase

See: Pull Request Guidelines

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant refactoring of the webOS platform layer, generalizing it for Linux and abstracting webOS-specific components. It also adds support for Matter 1.5 specifications, including new features like NFC commissioning and OTA updates. The changes improve the codebase by using more robust patterns, such as a managed GLib event loop instead of detached threads, better error handling, and a more modular design for BLE and mDNS services. My review focuses on ensuring the correctness and safety of the new and refactored logic. I've identified a few areas for improvement, including removing debug logs, adding a missing bounds check to prevent data loss, and correcting a risky integer comparison. Overall, this is a substantial and high-quality contribution.

Copy link

PR #40796: Size comparison from a05e91d to 34e9204

Full report (3 builds for realtek, stm32)
platform target config section a05e91d5 34e9204 change % change
realtek light-switch-app rtl8777g FLASH 703464 703464 0 0.0
RAM 106660 106660 0 0.0
lighting-app rtl8777g FLASH 755224 755224 0 0.0
RAM 127040 127040 0 0.0
stm32 light STM32WB5MM-DK FLASH 467724 467724 0 0.0
RAM 141400 141400 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant