Move accelerator function to codeflare-common support #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChughShilpa
force-pushed
the
add_function
branch
from
1feefd6 to
b9a8e1d
Compare
sutaakar
reviewed
Mar 13, 2025
support/accelerator.go
Outdated
|
|
||
| var ( | ||
| AMD = Accelerator{ResourceLabel: "amd.com/gpu"} | ||
| CPU = Accelerator{ResourceLabel: "nvidia.com/gpu"} |
There was a problem hiding this comment.
Why is the resource label defined for CPU?
There was a problem hiding this comment.
It is needed in the same test where you suggested this use Accelerator - https://github.com/project-codeflare/codeflare-operator/pull/670/files#r1986737951
Test runs with cpus and defining this label "nvidia.com/gpu" is mandatory in clusterqueue
ChughShilpa
force-pushed
the
add_function
branch
2 times, most recently
from
e396ec9 to
cfdf113
Compare
ChughShilpa
force-pushed
the
add_function
branch
from
cfdf113 to
8b00556
Compare
sutaakar
approved these changes
Mar 13, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChughShilpa, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 51d8946
into
project-codeflare:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Move accelerator function to codeflare-common support from https://github.com/opendatahub-io/distributed-workloads/blob/main/tests/kfto/support.go
Verification steps
NA
Checks