CLI Layout and Create RayCluster function #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MichaelClifford
requested changes
Jul 21, 2023
Maxusmusti
requested changes
Jul 21, 2023
There was a problem hiding this comment.
Off to a good start! Just one thing I noticed initially:
- Running
codeflare create rayclusterfor me causesFileNotFoundError: [Errno 2] No such file or directory: '/Users/meyceoz/Documents/codeflare-sdk/src/codeflare_sdk/cli/commands/create.py'. I realized after that the command was changed todefinebut the CLI should be able to handle erroneous input. For example, if i writecodeflare pizza, right now it will tell meFileNotFoundError: [Errno 2] No such file or directory: '/Users/meyceoz/Documents/codeflare-sdk/src/codeflare_sdk/cli/commands/pizza.py'. Basically, just make sure you are checking that commands are valid too, not just options, and if not just tell the user it is invalid and to check--helpfor more details. I thinkclickmay have something for this as well.
|
@carsonmh looks good. Thanks for the changes. However, your commit history looks like you merged previous commits instead of re-baseing. Can you update this PR so that it only includes your commits? Thanks |
|
@MichaelClifford it should be fixed now |
Maxusmusti
requested changes
Jul 25, 2023
|
@MichaelClifford if it looks good to you, feel free to merge |
MichaelClifford
approved these changes
Jul 25, 2023
Maxusmusti
pushed a commit
that referenced
this pull request
Jul 31, 2023
* Create: base and file layout for CLI * Add: Create raycluster command for CLI * Refactor: refactor CLI using pre-commit * Test: unit tests for create raycluster function in the CLI * Update: update egg-info with more paths * Change: change Framework Cluster to RayCluster * merge: rebase with main * Fix: unit tests * Change: create cluster to define cluster in unit tests * Add: error handling for invalid command * test: change tests so cli cluster definition has its own yaml file
carsonmh
added a commit
that referenced
this pull request
Aug 11, 2023
* Create: base and file layout for CLI * Add: Create raycluster command for CLI * Refactor: refactor CLI using pre-commit * Test: unit tests for create raycluster function in the CLI * Update: update egg-info with more paths * Change: change Framework Cluster to RayCluster * merge: rebase with main * Fix: unit tests * Change: create cluster to define cluster in unit tests * Add: error handling for invalid command * test: change tests so cli cluster definition has its own yaml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #218
Creates layout, configuration, build configuration, and create raycluster command for the CLI. After building, get started with
codeflare --helpor justcodeflareHow to test
pytest -v tests/unit_test.pyorpython -m pytest tests/unit_test.pycodeflare create raycluster [options]command. This should create the yaml file with the specified options. Options should be in the format:--name=cluster-nameor--machine_types='["gpu.large"]'