Update packages #275
Closed
Update packages #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@KPostOffice Is the thoth-python package something we still want to use? |
Fiona-Waters
force-pushed
the
update-packages
branch
from
b6ca10a
to
ada0cfe
Compare
Fiona-Waters
force-pushed
the
update-packages
branch
from
ada0cfe
to
bf877ff
Compare
|
Closing as dependencies will be updated with new notebook base image and do not need to be updated now. |
Fiona-Waters
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#210
What changes have been made
Lastest versions of openshift and thoth-python packages have been added to requirements.txt.
beautifulsoup4 version has been updated also to allow for use of thoth-python and others that require it.
*edit: thoth-python package is no longer maintained - removed this and the update to beautifulsoup4
Verification steps
From this PR run
Check that it builds successfully with no errors.
Checks