Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli update #301

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Cli update #301

wants to merge 47 commits into from

Conversation

carsonmh
Copy link
Contributor

@carsonmh carsonmh commented Aug 11, 2023

Issue link

closes #284

What changes have been made

Codeflare CLI, adding a command line interface that allows similar functionality to the Codeflare SDK.
Changes to SDK include:

  • creating Cluster object from yaml function
  • refactored some parts of the Codeflare SDK
  • allow app wrapper creation to be optional

Verification steps

-codeflare --help to see a list of all commands, run each one to test

  • You can run unit tests with pytest

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

carsonmh and others added 30 commits August 11, 2023 12:07
* Create: base and file layout for CLI

* Add: Create raycluster command for CLI

* Refactor: refactor CLI using pre-commit

* Test: unit tests for create raycluster function in the CLI

* Update: update egg-info with more paths

* Change: change Framework Cluster to RayCluster

* merge: rebase with main

* Fix: unit tests

* Change: create cluster to define cluster in unit tests

* Add: error handling for invalid command

* test: change tests so cli cluster definition has its own yaml file
* Add: create_api_client_config helper function for the SDK

* Add: login function for CLI

* Change: change options and help for login function

* Create: logout function

* Test: add unit tests for login and logout functions

* add: additional error handling and change layout slightly

* test: add unit test for load_auth

* change: make tls skip false by default

* add: make authentication go into .codeflare

* test: add unit tests for checking validity of auth file and split login/logout tests
* add: create cluster from yaml function

* add: submit and delete functions

* change: cluster_name to name in submit raycluster

* add: load_auth in delete function

* update: make get_cluster function use new config

* test: unit tests for submit and delete raycluster commands

* change: format slightly on submit/delete commands

* Add: context for current namespace and .codeflare path

* fix: remove load_auth in functions so it doesn't run twice

* Add: help messages for submit and delete functions

* cleanup

* remove: remove get_namespace every function call

* fix: fix tests

* change: make namespace default to 'default'
and change test slightly

* refactor: remove unused imports
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maxusmusti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge CodeFlare CLI into main
2 participants