Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in base-template.yaml #304

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Fix typo in base-template.yaml #304

merged 2 commits into from
Aug 15, 2023

Conversation

revit13
Copy link
Contributor

@revit13 revit13 commented Aug 13, 2023

This PR contains a minor typo fix to base-template.yaml

@accorvin
Copy link

@revit13 thank you for the PR!

@Maxusmusti @dimakis can you all take a look?

dimakis
dimakis approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
Maxusmusti
Maxusmusti requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you update the tests as well? (Guessing it will just be updating the yamls in the test dir with the same replica->replicas)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@revit13
Fix tests.
95810ed 
Signed-off-by: Revital Sur <[email protected]>
@revit13
Copy link
Contributor Author

revit13 commented Aug 15, 2023

Looks good, but could you update the tests as well? (Guessing it will just be updating the yamls in the test dir with the same replica->replicas)

@Maxusmusti Done, Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimakis, MichaelClifford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 98fec4b into project-codeflare:main Aug 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimakis dimakis dimakis approved these changes

@MichaelClifford MichaelClifford MichaelClifford approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

Assignees

@MichaelClifford MichaelClifford

@Maxusmusti Maxusmusti

@revit13 revit13

@dimakis dimakis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@revit13 @accorvin @MichaelClifford @Maxusmusti @dimakis @openshift-merge-robot