Skip to content

Create a Ray Cluster SDK upgrade scenarios #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

Create a Ray Cluster SDK upgrade scenarios #440

merged 1 commit into from
Jan 19, 2024

Conversation

Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Jan 11, 2024 •
edited
Loading

Issue link

closes project-codeflare/codeflare-operator#184

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

ChristianZaccaria
ChristianZaccaria requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few requested changes, thanks Srihari!

@Srihari1192 Srihari1192 mentioned this pull request Jan 16, 2024
Closed
4 tasks
astefanutti
astefanutti approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: astefanutti
Once this PR has been reviewed and has the lgtm label, please assign fiona-waters for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astefanutti astefanutti merged commit 65ed743 into project-codeflare:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

@sutaakar sutaakar Awaiting requested review from sutaakar

@ChristianZaccaria ChristianZaccaria Awaiting requested review from ChristianZaccaria

Assignees

@astefanutti astefanutti

@ChristianZaccaria ChristianZaccaria

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create upgrade e2e scenario covering upgrade during training
3 participants
@Srihari1192 @astefanutti @ChristianZaccaria