Skip to content

RHOAIENG-10371 - Clean up content of cells in SDK demo notebooks #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jiripetrlik
Copy link
Contributor

No description provided.

@jiripetrlik jiripetrlik requested review from Fiona-Waters and removed request for astefanutti and KPostOffice August 26, 2024 13:30
Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiripetrlik this looks good but the e2e is failing due to a kueue webhook error which I assume is unrelated to your changes.

@jiripetrlik
Copy link
Contributor Author

@Fiona-Waters
Thank you for review. Yes, the failure in E2E tests is not related to changes in demo notebooks. Confirmed today with @sutaakar . Will try to fix the issue in new PR. Can you approve this PR?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
@sutaakar sutaakar added the test-guided-notebooks Run PR check to verify Guided notebooks label Aug 27, 2024
@sutaakar
Copy link
Contributor

rerunning failed job....

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 261da3f into project-codeflare:main Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-guided-notebooks Run PR check to verify Guided notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants