-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] Design doc for CodeFlare SDK #703
[Add] Design doc for CodeFlare SDK #703
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 36 36
Lines 2412 2412
=======================================
Hits 2270 2270
Misses 142 142 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work Varsha. I've a couple of comments
f2eb95b
to
63cf20c
Compare
c72f652
to
648b374
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small nits but otherwise this lgtm!
648b374
to
41df024
Compare
Just need to resolve conflict and it lgtm |
This PR adds design documentation for CodeFlare SDK to the repository for reference in future.
41df024
to
f2602fd
Compare
@Bobbins228 could you approve the PR if everything looks good? Thanks! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work Varsha, Bualadh bos(Irish for applause)!
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, franciscojavierarceo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds design documentation for CodeFlare SDK to the repository for reference in future.
Issue link
What changes have been made
Verification steps
Checks