fix: cluster configuration validation for bool type #777
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ygnas
requested review from
KPostOffice,
Bobbins228 and
ChristianZaccaria
and removed request for
dimakis and
Fiona-Waters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
==========================================
+ Coverage 93.04% 93.07% +0.02%
==========================================
Files 36 36
Lines 2402 2410 +8
==========================================
+ Hits 2235 2243 +8
Misses 167 167 ☔ View full report in Codecov by Sentry. |
KPostOffice
reviewed
Dec 5, 2024
As bool is a subtype of int, True/False was considered as 1/0
Bobbins228
reviewed
Dec 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit be9763a
into
project-codeflare:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-11022
What changes have been made
Fixed cluster configuration validation for bool types, and changed so all type mismatches are reported simultaneously, rather than stopping at the first occurrence.
Verification steps
Checks