fix: cluster configuration validation for bool type#777
fix: cluster configuration validation for bool type#777openshift-merge-bot[bot] merged 1 commit intoproject-codeflare:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
==========================================
+ Coverage 93.04% 93.07% +0.02%
==========================================
Files 36 36
Lines 2402 2410 +8
==========================================
+ Hits 2235 2243 +8
Misses 167 167 ☔ View full report in Codecov by Sentry. |
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Small nitpick, but looks good! I'll give it a test tomorrow.
As bool is a subtype of int, True/False was considered as 1/0
Bobbins228
left a comment
There was a problem hiding this comment.
Tested it out and works great
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
https://issues.redhat.com/browse/RHOAIENG-11022
What changes have been made
Fixed cluster configuration validation for bool types, and changed so all type mismatches are reported simultaneously, rather than stopping at the first occurrence.
Verification steps
Checks