-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix coverage badge wf and omit test files from unit test coverage #783
ci: fix coverage badge wf and omit test files from unit test coverage #783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varshaprasad96, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c8e77fc
into
project-codeflare:main
thanks @Bobbins228 , this is somehting I have noticed while trying to push my PR; and it was biasing the coverage results. |
A .coveragerc file could be good! Would help rather than having to make sure 2 workflows and documentation are kept updated. I will look into this thanks Akram 👍 |
Issue link
What changes have been made
Verification steps
Run
coverage run --omit="src/**/test_*.py,src/codeflare_sdk/common/utils/unit_test_support.py" -m pytest
and verify the unit test files are not included when you runcoverage report
Checks