-
Notifications
You must be signed in to change notification settings - Fork 95
feat: Bulk Image Patching #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: amanycodes <[email protected]>
Signed-off-by: amanycodes <[email protected]>
Signed-off-by: amanycodes <[email protected]>
Signed-off-by: amanycodes <[email protected]>
Signed-off-by: amanycodes <[email protected]>
Signed-off-by: amanycodes <[email protected]>
Signed-off-by: amanycodes <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 42.86% 42.42% -0.45%
==========================================
Files 35 38 +3
Lines 4122 4427 +305
==========================================
+ Hits 1767 1878 +111
- Misses 2224 2414 +190
- Partials 131 135 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. Great to see copa get a config file! This is a great addition, thanks!
Signed-off-by: amanycodes <[email protected]>
pkg/cmd/cmd.go
Outdated
Short: "Patch container images with upgrade packages specified by a vulnerability report", | ||
Example: "copa patch -i images/python:3.7-alpine -r trivy.json -t 3.7-alpine-patched", | ||
Use: "patch", | ||
Short: "Patch container images with upgrade packages specified by a vulnerability report or by comprehensive update", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is the initial scope:
Short: "Patch container images with upgrade packages specified by a vulnerability report or by comprehensive update", | |
Short: "Patch container images with upgrade packages specified by comprehensive update", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sozercan but this short is for the patch command as a whole right? not just bulk image patch. maybe we can specify comprehensive update for bulk additionally.
@@ -1,32 +0,0 @@ | |||
package patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did this get removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd.go was moved to its own package (pkg/cmd) as i was having cyclic dependencies.
Signed-off-by: amanycodes <[email protected]>
Signed-off-by: Aman <[email protected]>
This PR introduces bulk patching for copa that allows user to patch multiple container images by passing a single YAML config file path in the
--config
flag.eg:
copa patch --config path/config.yaml
This is the initial implementation which focuses on the "comprehensive/update-all" patching foundational for report based bulk image patching for future prospects.
The design doc which this is implemented on: Bulk Image Patching
Closes #631