Added Getting Started, Basic Concepts, How to Write Policies #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmann
approved these changes
Feb 20, 2025
goldmann
reviewed
Feb 20, 2025
goldmann
reviewed
Feb 20, 2025
goldmann
reviewed
Feb 20, 2025
goldmann
reviewed
Feb 20, 2025
goldmann
reviewed
Feb 20, 2025
goldmann
reviewed
Feb 20, 2025
goldmann
reviewed
Feb 20, 2025
goldmann
reviewed
Feb 20, 2025
|
Oh, there is one more thing, can you make sure all commits are following the conventional commits standard? This one should be hopefully to apply. Thanks! |
|
@goldmann thanks for the great feedback! I tried to address all of the reviews and also did another proof-read to fix some more typos I found |
Which means to just add the I'll later add an action to validate/enforce it as part of the PR checks. |
mertbugrabicak
force-pushed
the
policy-write-test-docs
branch
from
65d0a7e to
ebf8229
Compare
|
@goldmann I just did an interactive rebase and added docs: prefixes to all commits, I hope it all looks okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the Getting Started section for our project as well as the basic concepts around policies, and how to actually structure them in Rego. Also there are some other sections added to fill in later such as the Project Goals and Unit Testing