Skip to content

Index names on components so search works as expected #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

corylown
Copy link
Contributor

@corylown corylown commented Jun 6, 2025

Fixes #1608

If this gets merged I'll backport it to release-1.x

There's some related history, including that we seem to have deliberately left this out, but I'm not seeing a convincing reason why and a follow up issue was created to revisit. I can't see the harm in indexing names on components in names_ssim so they are searchable. And we have gotten at least one report of this as a problem.

Some things about how the existing SolrEAD setup indexes names data strike me as likely unintentional. E.g., at the component level only names wrapped in <controlaccess> get added to names_ssim but at the document/collection level names_ssim includes component names that aren't wrapped in <controlaccess>. But I thought better to try to stick to achieving parity for now, and revise this sort of thing later.

@corylown corylown marked this pull request as ready for review June 6, 2025 16:12
@seanaery seanaery merged commit 2fcfe48 into main Jun 9, 2025
5 checks passed
@seanaery seanaery deleted the 1608-index-component-names branch June 9, 2025 16:32
marlo-longley added a commit that referenced this pull request Jun 9, 2025
Index names on components so search works as expected (#1613)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creator metadata not showing up in components on search
3 participants