Index names on components so search works as expected #1613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1608
If this gets merged I'll backport it to
release-1.x
There's some related history, including that we seem to have deliberately left this out, but I'm not seeing a convincing reason why and a follow up issue was created to revisit. I can't see the harm in indexing names on components in
names_ssim
so they are searchable. And we have gotten at least one report of this as a problem.