Skip to content

Improving testing matrix #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2025
Merged

Improving testing matrix #190

merged 3 commits into from
May 13, 2025

Conversation

cgalarza
Copy link
Contributor

@cgalarza cgalarza commented May 13, 2025 •
edited
Loading

Adding testing for:

  • Ruby 3.4 / Rails 7.2 / Blacklight 7 / Sprockets
  • Ruby 3.2 / Rails 7.1 / Blacklight 7 / Sprockets
  • Ruby 3.4 / Rails 8 / Blacklight Edge / CSS Bundling

Close #184

@cgalarza cgalarza force-pushed the improving-testing-matrix branch from 0bcce89 to 4257a8f Compare May 13, 2025 15:34
@cgalarza cgalarza marked this pull request as ready for review May 13, 2025 15:34
jcoyne
jcoyne reviewed May 13, 2025
View reviewed changes
jcoyne
jcoyne requested changes May 13, 2025
View reviewed changes
Copy link
Member

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we continue to have testing on ruby 3.2 & 3.3. as well?

@cgalarza
Copy link
Contributor Author

@jcoyne I took it out because it seemed like blacklight and blacklight engines were only supporting 3.4, but now I see that support for 3.2 and 3.3 is sprinkled in some of the includes. I'll add back in support for 3.2 and 3.3 at the top level matrix and for BL 7. Thanks for catching this and taking a look!

@cgalarza cgalarza requested a review from jcoyne May 13, 2025 16:54
jcoyne
jcoyne reviewed May 13, 2025
View reviewed changes
Copy link
Member

@jcoyne jcoyne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a 3.3 build as well, right?

i see that was reverted.

@jcoyne jcoyne merged commit fa6520a into main May 13, 2025
7 checks passed
@jcoyne jcoyne deleted the improving-testing-matrix branch May 13, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne jcoyne requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider Sprockets in test matrix
2 participants
@cgalarza @jcoyne