Skip to content

Convert gallery scss to css #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025
Merged

Convert gallery scss to css #197

merged 4 commits into from
May 14, 2025

Conversation

body-clock
Copy link
Member

✅ Tested working on Blacklight 9 (main branch)

I think the only consideration here that potientially needs a bit of discussion is changing this:

  .index_title {
    @extend .h6;
  }

to

  .index_title {
    font-size: 1.25rem;
  }

Unlike the .caption class, the .index_title class is used in Blacklight core - this would involve a template override. I think the potential maintenance overhead of an override is significantly more than evaluating whether a font-size of 1.25rem is close enough to the Bootstrap .h6 class. I tested in browser and I think they look similar enough. I'm certainly open to more suggestions, though.

@body-clock body-clock linked an issue May 14, 2025 that may be closed by this pull request
5 tasks
@body-clock body-clock added this to the 5.0 milestone May 14, 2025
@body-clock body-clock changed the title 193 convery gallery scss to css Convert gallery scss to css May 14, 2025
@jcoyne jcoyne merged commit 443a9f6 into main May 14, 2025
7 checks passed
@jcoyne jcoyne deleted the 193-convery-gallery-scss-to-css branch May 14, 2025 18:54
@cgalarza
Copy link
Contributor

I didn't think we wanted to merge this yet because it uses CSS variables which aren't supported in Bootstrap 4. We wanted to cut a version of blacklight-gallery v4 before merging and moving onto v5.

@cgalarza cgalarza restored the 193-convery-gallery-scss-to-css branch May 14, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert gallery SCSS to CSS
3 participants