Skip to content

Convert Gallery SCSS to CSS #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
Merged

Convert Gallery SCSS to CSS #200

merged 4 commits into from
May 22, 2025

Conversation

body-clock
Copy link
Member

@body-clock body-clock commented May 14, 2025

Closes #193

We're waiting until after we cut a v4 release and move main target v5 to merge this.

@body-clock body-clock changed the title 193 restored gallery conversion Convert Gallery SCSS to CSS May 14, 2025
@body-clock body-clock added this to the 5.0 milestone May 14, 2025
@body-clock body-clock requested a review from Copilot May 14, 2025 20:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts Gallery SCSS files to plain CSS by replacing SCSS features (such as @extend and SCSS variables) with equivalent CSS classes and CSS variables. It also adjusts HTML markup to utilize Bootstrap spacing utilities.

  • Converted SCSS styles to CSS by removing @extend statements and SCSS variables in favor of CSS variables and explicit style rules.
  • Updated the component markup to include the "mt-2" class for margin adjustments.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
app/components/blacklight/gallery/document_component.html.erb Added "mt-2" class to the caption container to adjust spacing
app/assets/stylesheets/blacklight_gallery/_gallery.css Replaced SCSS constructs (@extend, SCSS variables) with CSS equivalents
Comments suppressed due to low confidence (1)

app/assets/stylesheets/blacklight_gallery/_gallery.css:41

  • The new usage of CSS variables (var(--bs-border-width) and var(--bs-border-color)) assumes that these variables are defined and available globally. Please verify that these variables are properly configured in the project to ensure consistent styling.
.documents-gallery,

@mamrey mamrey self-requested a review May 17, 2025 11:34
@mamrey mamrey merged commit 7ee4f0d into main May 22, 2025
7 checks passed
@mamrey mamrey deleted the 193-restored-gallery-conversion branch May 22, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert gallery SCSS to CSS
2 participants