-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable building css so that you can run blacklight without sass #3184
base: main
Are you sure you want to change the base?
Conversation
61c1d52
to
943e723
Compare
d5632fe
to
56b475a
Compare
18117cd
to
e55ba59
Compare
83a7651
to
ae57225
Compare
1a09756
to
da21431
Compare
I'm trying to follow why it requires a new Also does this require a new CI build, or since CSS isn't really super testable by CI not worth it, or other reason it's not required? |
@jrochkind the |
Thanks @jcoyne You building on gem release, then? I had missed that, I had imagined it was building on assets:precompile for the app. Did I have it wrong, you are choosing to build on gem release and bundle built css with released gem? |
@jrochkind Yes, the idea here is that we ship precompiled CSS so that the user doesn't need to install Sass (unless they want to). This should make it easier for new adopters as they don't need to worry about any node dependencies. |
2f95601
to
d64dffa
Compare
Fixes #3206