Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building css so that you can run blacklight without sass #3184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jun 7, 2024

Fixes #3206

@jcoyne jcoyne force-pushed the build-css branch 5 times, most recently from 61c1d52 to 943e723 Compare June 13, 2024 20:52
@jcoyne jcoyne force-pushed the build-css branch 3 times, most recently from d5632fe to 56b475a Compare June 20, 2024 15:58
@jcoyne jcoyne force-pushed the build-css branch 10 times, most recently from 18117cd to e55ba59 Compare October 22, 2024 01:12
@jcoyne jcoyne marked this pull request as ready for review October 22, 2024 04:03
@jcoyne jcoyne added this to the 9.X milestone Oct 22, 2024
@jcoyne jcoyne force-pushed the build-css branch 9 times, most recently from 83a7651 to ae57225 Compare October 22, 2024 14:37
@jrochkind
Copy link
Member

jrochkind commented Nov 2, 2024

I'm trying to follow why it requires a new build.css css file, what made the previous top-level CSS file not pre-compilable/buildable?

Also does this require a new CI build, or since CSS isn't really super testable by CI not worth it, or other reason it's not required?

@jcoyne
Copy link
Member Author

jcoyne commented Nov 4, 2024

@jrochkind the build.css is needed so that we have an entrypoint to build from within the gem. In the past we've used application.scss within the host application as the entrypoint.

@jrochkind
Copy link
Member

Thanks @jcoyne

You building on gem release, then?

I had missed that, I had imagined it was building on assets:precompile for the app. Did I have it wrong, you are choosing to build on gem release and bundle built css with released gem?

@jcoyne
Copy link
Member Author

jcoyne commented Nov 4, 2024

@jrochkind Yes, the idea here is that we ship precompiled CSS so that the user doesn't need to install Sass (unless they want to). This should make it easier for new adopters as they don't need to worry about any node dependencies.

@jcoyne jcoyne force-pushed the build-css branch 6 times, most recently from 2f95601 to d64dffa Compare November 7, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable running blacklight without Sass
2 participants