Skip to content

Conversation

@jcoyne
Copy link
Member

@jcoyne jcoyne commented Aug 7, 2024

Screenshot 2024-08-07 at 10 04 19 AM

This was not available in Bootstrap 4. It allows a lot more customization (via Bootstrap variables) and requires Blacklight itself to have less code.

@jcoyne jcoyne added this to the 9.X milestone Aug 7, 2024
@jrochkind
Copy link
Member

After this PR, does facet list still work with Bootstrap 4, or is this a clean break requiring Bootstrap 5?

If it's a clean break, and that's what the community wants, then please make sure that's clearly noted in release notes for version that includes this? Also to avoid confusion probably remove the config bootstrap_version, and possibly remove other support for bootstrap 4?

@jcoyne
Copy link
Member Author

jcoyne commented Aug 7, 2024

@jrochkind this is only for BS 5 and it can be merged after #3226 is in place.

@jcoyne jcoyne force-pushed the facet-accordion branch 4 times, most recently from 691eb26 to 5e45938 Compare September 23, 2024 13:46
@jcoyne
Copy link
Member Author

jcoyne commented Oct 16, 2024

This is how IU is styling this component:
Screenshot 2024-10-16 at 10 27 18 AM

@jrochkind
Copy link
Member

We have long done similar styling in Blacklight 7/Boostrap 4, adding styles to make the facet menu look like this even in that situation.

Screenshot 2024-10-16 at 11 34 45 AM

https://digital.sciencehistory.org/catalog

@cbeer
Copy link
Member

cbeer commented Oct 22, 2024

If we're going to remove the whitespace and borders around each facet, I think we also need to change the background color of the accordion headers (like IU + SHI do) to visually distinguish between the header and the facet values.

@jcoyne
Copy link
Member Author

jcoyne commented Oct 22, 2024

Good suggestion @cbeer I've adjusted it as per this screenshot:

Screenshot 2024-10-22 at 1 14 55 PM

@jcoyne jcoyne force-pushed the facet-accordion branch 3 times, most recently from 33478ac to 68778b3 Compare October 22, 2024 18:23
@jcoyne jcoyne merged commit 66540b3 into main Nov 4, 2024
13 checks passed
@jcoyne jcoyne deleted the facet-accordion branch November 4, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants