Change bookmarkCounter to find multiple selectors #3351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbergja
reviewed
Oct 5, 2024
Contributor
sandbergja
left a comment
sandbergja
left a comment
There was a problem hiding this comment.
Thanks, @kirkkwang ! Looks like a good change to me, I just had two suggestions.
This commit will change the bookmarkCounter function to look for multiple selectors instead of one. This way if we want to put the bookmark counter elsewhere it will also be dynamic. Ref: - projectblacklight#3350
Contributor
Author
|
@sandbergja thank you so much! I've made the suggested changes. |
cbeer
pushed a commit
that referenced
this pull request
Oct 23, 2024
This commit will change the bookmarkCounter function to look for multiple selectors instead of one. This way if we want to put the bookmark counter elsewhere it will also be dynamic. Ref: - #3350
cbeer
pushed a commit
that referenced
this pull request
Oct 23, 2024
This commit will change the bookmarkCounter function to look for multiple selectors instead of one. This way if we want to put the bookmark counter elsewhere it will also be dynamic. Ref: - #3350
sandbergja
added a commit
to pulibrary/orangelight
that referenced
this pull request
Nov 6, 2024
…ve a bookmark. Currently, this test passes on Blacklight 7, fails on Blacklight 8.3, and passes on Blacklight 8.6.1 thanks to @kirkkwang 's work in projectblacklight/blacklight#3351 Helps with #4539
sandbergja
added a commit
to pulibrary/orangelight
that referenced
this pull request
Nov 6, 2024
…ve a bookmark. Currently, this test passes on Blacklight 7, fails on Blacklight 8.3, and passes on Blacklight 8.6.1 thanks to @kirkkwang 's work in projectblacklight/blacklight#3351 Helps with #4539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will change the bookmarkCounter function to look for multiple selectors instead of one. This way if we want to put the bookmark counter elsewhere it will also be dynamic.
Ref: