Remove vestiges of turbolinks #3356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't understand this stuff, so believe you that we don't need it anymore and love to see it go. Can any of these conditional event names also be removed, are any of them for old turbolinks stuff no longer needed to support? (In my head since I was just looking at them to debug the mystifying problem we were talking about in slack) blacklight/app/javascript/blacklight/core.js Lines 16 to 26 in 2e95685 |
| <% end %> | ||
|
|
||
| <% content_for(:skip_links) do -%> | ||
| <%= link_to t('blacklight.skip_links.first_result'), '#documents', class: 'd-inline-flex p-2 m-1', data: { turbolinks: 'false' } %> |
Member
There was a problem hiding this comment.
shouldn't this be data: { turbo: false }?
Member
Author
There was a problem hiding this comment.
I don't think that turbo needs to skip this. I'm pretty sure it knows that intra-document links don't get cached.
jcoyne
force-pushed
the
remove-turbolinks
branch
from
a309280 to
4be68b0
Compare
jrochkind
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.