Workaround bug in devise #3368
Merged
Workaround bug in devise #3368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously thought there was a bug in Rails or Propshaft which we were working around by precompiling assets in test. However, further analysis led us to conclude the problem is really in the default configuration for Devise. It prevents other engines (like propshaft) from loading their routes when config.eager_load=true See heartcombo/devise#5720
jrochkind
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously thought there was a bug in Rails or Propshaft which we were working around by precompiling assets in test. However, further analysis led us to conclude the problem is really in the default configuration for Devise. It prevents other engines (like propshaft) from loading their routes when config.eager_load=true
See heartcombo/devise#5720