Directly use the visually-hidden class #3373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrochkind
reviewed
Oct 22, 2024
| <%= link_to url, title: label, class: "#{Array(@classes).join(' ')} view-type-#{ @key.to_s.parameterize } #{"active" if selected?}" do %> | ||
| <%= icon %> | ||
| <span class="caption"><%= label %></span> | ||
| <span class="visually-hidden"><%= label %></span> |
Member
There was a problem hiding this comment.
does it make sense to leave caption there too for anyone that might have or want to target it for custom style override?
Just asking the question, you can say no!
Member
Author
There was a problem hiding this comment.
I don't see any harm in doing that. I've pushed this back in.
This allows us to remove a SASS @extend, which will allow us to decouple from SASS
jcoyne
force-pushed
the
visually-hidden
branch
from
c9bbf93 to
0825da1
Compare
thatbudakguy
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove a SASS @extend, which will allow us to decouple from SASS