Skip to content

ClausePresenter: don't attempt to call #display_label on a non-existant field configuration #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ClausePresenter: don't attempt to call #display_label on a non-existant field configuration #3442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/presenters/blacklight/clause_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def initialize(key, user_parameters, field_config, view_context, search_state =
end

def field_label
field_config.display_label('search')
field_config&.display_label('search')
end

##
Expand Down
12 changes: 12 additions & 0 deletions spec/presenters/blacklight/clause_presenter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,18 @@
it 'returns a label for the field' do
expect(subject.field_label).to eq 'Some Field'
end

context 'when the field config does not exist' do
let(:field_config) { nil }

it 'returns nil' do
expect(subject.field_label).to be_nil
end

it 'does not raise an error' do
expect { subject.field_label }.not_to raise_error
end
end
end

describe '#label' do
Expand Down