[backport 8.x] Fix CI via updating versions of Rails tested & Solr 9.8 fix #3500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r 9.8 compatibility As a result of https://issues.apache.org/jira/browse/SOLR-16781, <lib> entries are now ignored by default. The Solr guide recommends adding them to the solr.modules system property or the SOLR_MODULES envvar instead: https://solr.apache.org/guide/solr/latest/configuration-guide/solr-modules.html Closes #3496 and helps to unbreak CI
- Use latest 8.0, 7.2, 7.1 releases - Stop testing 6.x
sandbergja
approved these changes
Jan 29, 2025
Contributor
sandbergja
left a comment
sandbergja
left a comment
There was a problem hiding this comment.
Thank you very much, @seanaery !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propshaft&esbuildNote: This PR's primary aim is to get the test suite passing again in CI for the
release-8.xbranch, especially to facilitate future backports. Rails versions below 7.1 are all now EOL. There's a bug at the Rails core level in pre-7.1 (see #3493) that complicates testing. This PR removes the last vestiges of pre-7.1 versions from the CI matrix for Blacklight 8.x but still retains existing>= 6.1compatibility via the.gemspec.Implementers using Blacklight 8 with EOL Rails < 7.1 may need to pin the
concurrent-rubygem to< 1.3.5