Skip to content

Conversation

@seanaery
Copy link
Contributor

…ny supported version of Solr without requiring workarounds. Fixes #3738.

@seanaery seanaery marked this pull request as draft August 25, 2025 12:29
@seanaery seanaery force-pushed the 3738-fix-advanced-search branch from 4ac1e53 to 26fb5da Compare August 25, 2025 13:33
@seanaery seanaery marked this pull request as ready for review August 25, 2025 13:39
@seanaery
Copy link
Contributor Author

Tagging a couple developers as a heads-up, as this builds on / incorporates ideas from your documented workarounds:

  • @sandbergja - This makes the clause_params workaround you helpfully documented in the wiki just happen automatically; it also makes things work consistently across Solr 7, 8, 9 without an implementer having to do anything special for different versions.
  • @body-clock - This incorporates the approach you documented in the wiki for getting a default -1 facet limit for each facet when in the advanced search page; it'd now just get configured like that automatically using the existing facet_fields but can be fine-tuned with additional config if needed.

@seanaery seanaery force-pushed the 3738-fix-advanced-search branch from 26fb5da to afec076 Compare August 27, 2025 17:27
@mamrey mamrey self-requested a review September 20, 2025 10:15
Copy link
Contributor

@mamrey mamrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @seanaery! The advanced search now works as expected, without any configuration, in the development app. This makes it so much easier to work on the advanced search feature and use it in an app. Thanks for the additional tests and documentation that clearly express the new behavior. I left a question and a non-blocking suggestion for an additional test, but I've gone ahead and approved.

…ny supported version of Solr without requiring workarounds. Fixes #3738.

- Use existing search_field config to dynamically set the clause_params required for use by Solr JSON Query DSL.
- Automatically display all values (limit: -1) for any facets rendered in Advanced Search, so "more" modals aren't used. Advances #3236.
- Add optional config.advanced_search.form_solr_parameters to enable fine-tuning each advanced search facet config as needed.
- Document advanced search configuration options, e.g., include_in_advanced_search. Closes #3681.
- Remove the duplicative `/advanced` Solr requestHandler workaround added in #3066; return to using the existing `/select` config for advanced; but still retain option to configure a separate handler if desired.
- Instead, we just set the top-level defType to lucene automatically whenever clause_params are used (JSON Query DSL); this fixes searching in Solr 7.2-9.3.
- Enable Advanced Search by default and render the link to it.
- Change the `More options` button (that leads to the form) into an `Advanced search` link. Closes #3681.
@seanaery seanaery force-pushed the 3738-fix-advanced-search branch from afec076 to bde9abb Compare September 23, 2025 17:43
@mamrey mamrey merged commit 312af3c into main Sep 29, 2025
12 checks passed
@mamrey mamrey deleted the 3738-fix-advanced-search branch September 29, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advanced search form text fields don't work without workarounds Advanced search link should appear by default

3 participants