-
Notifications
You must be signed in to change notification settings - Fork 253
Make the built-in advanced search work correctly out-of-the-box for a… #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ac1e53 to
26fb5da
Compare
|
Tagging a couple developers as a heads-up, as this builds on / incorporates ideas from your documented workarounds:
|
26fb5da to
afec076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @seanaery! The advanced search now works as expected, without any configuration, in the development app. This makes it so much easier to work on the advanced search feature and use it in an app. Thanks for the additional tests and documentation that clearly express the new behavior. I left a question and a non-blocking suggestion for an additional test, but I've gone ahead and approved.
…ny supported version of Solr without requiring workarounds. Fixes #3738. - Use existing search_field config to dynamically set the clause_params required for use by Solr JSON Query DSL. - Automatically display all values (limit: -1) for any facets rendered in Advanced Search, so "more" modals aren't used. Advances #3236. - Add optional config.advanced_search.form_solr_parameters to enable fine-tuning each advanced search facet config as needed. - Document advanced search configuration options, e.g., include_in_advanced_search. Closes #3681. - Remove the duplicative `/advanced` Solr requestHandler workaround added in #3066; return to using the existing `/select` config for advanced; but still retain option to configure a separate handler if desired. - Instead, we just set the top-level defType to lucene automatically whenever clause_params are used (JSON Query DSL); this fixes searching in Solr 7.2-9.3. - Enable Advanced Search by default and render the link to it. - Change the `More options` button (that leads to the form) into an `Advanced search` link. Closes #3681.
afec076 to
bde9abb
Compare
…ny supported version of Solr without requiring workarounds. Fixes #3738.
/advancedSolr requestHandler workaround added in Use a separate requestHandler for JSON DSL queries #3066; return to using the existing/selectconfig for advanced; but still retain option to configure a separate handler if desired.More optionsbutton (that leads to the form) into anAdvanced searchlink. Closes Advanced search link should appear by default #3681.